Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NonIdealState for empty DropZone #586

Merged
merged 4 commits into from
Dec 11, 2023
Merged

Use NonIdealState for empty DropZone #586

merged 4 commits into from
Dec 11, 2023

Conversation

moonayyur
Copy link
Contributor

closes #581

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2023 •
edited
Loading

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (707c929) 46.80% compared to head (1f4ed7a) 47.01%.
Report is 4 commits behind head on main.

Files Patch % Lines
src/components/drop-zone/DropZone.tsx 33.33% 28 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #586      +/-   ##
==========================================
+ Coverage   46.80%   47.01%   +0.20%     
==========================================
  Files         149      143       -6     
  Lines        7950     7519     -431     
  Branches      146      146              
==========================================
- Hits         3721     3535     -186     
+ Misses       4229     3984     -245

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

stropitek
stropitek reviewed Dec 4, 2023
View reviewed changes
Copy link
Contributor

@stropitek stropitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use a gray that is defined by blueprintjs for the default color of the dashed border?

You can import those colors from the library

@stropitek
Copy link
Contributor

Also the style (font size, weight etc.) should be more consistent between when there is a drop target and when there is none:

CleanShot.2023-12-04.at.10.09.03.mp4

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Dec 4, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1f4ed7a
Status: ✅  Deploy successful!
Preview URL: https://4734920b.react-science.pages.dev
Branch Preview URL: https://581-redo-design-of-dropzone.react-science.pages.dev

View logs

@stropitek
Copy link
Contributor

What happens when the dropzone has children has slightly changed. Before the children were still visible below an overlay.

Is it on purpose?

Before:

CleanShot.2023-12-05.at.08.43.24.mp4

After:

CleanShot.2023-12-05.at.08.42.06.mp4

@moonayyur
Copy link
Contributor Author

@stropitek this happened when I changed the colors to use the blueprint ones for the text, I have restored the background opacity

@stropitek stropitek merged commit 4ed7560 into main Dec 11, 2023
11 of 12 checks passed
@stropitek stropitek deleted the 581-redo-design-of-dropzone-component branch December 11, 2023 14:12
@zakodium-bot zakodium-bot mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stropitek stropitek stropitek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redo design of dropzone component
3 participants
@moonayyur @codecov-commenter @stropitek